[webkit-reviews] review granted: [Bug 187840] Animation stops with object-fit:contain on an animated 2d canvas : [Attachment 345735] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 187840: Animation stops with object-fit:contain on an animated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=187840

Attachment 345735: Patch

https://bugs.webkit.org/attachment.cgi?id=345735&action=review




--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 345735
  --> https://bugs.webkit.org/attachment.cgi?id=345735
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345735&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:511
> +    if (is<RenderReplaced>(renderBox())) {

The canvas renderer is not necessarily a RenderReplaced.