[webkit-reviews] review granted: [Bug 187971] Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it : [Attachment 345715] Patch and tests

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 187971: Move-constructing NeverDestroyed should move construct underlying
object instead of copy constructing it
https://bugs.webkit.org/show_bug.cgi?id=187971

Attachment 345715: Patch and tests

https://bugs.webkit.org/attachment.cgi?id=345715&action=review




--- Comment #10 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 345715
  --> https://bugs.webkit.org/attachment.cgi?id=345715
Patch and tests

View in context: https://bugs.webkit.org/attachment.cgi?id=345715&action=review

r=me

> Tools/ChangeLog:9
> +	   Fixes an issue where move constructing a NeverDestroyed<T> would
always copy construct T into
> +	   the destination storage buffer regardless of whether T is move
constructable. For example:

Do we really need this changelog copied here too?