[webkit-reviews] review granted: [Bug 187968] Refactoring: make DFG::Plan a class. : [Attachment 345702] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 12:48:27 PDT 2018


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 187968: Refactoring: make DFG::Plan a class.
https://bugs.webkit.org/show_bug.cgi?id=187968

Attachment 345702: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=345702&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 345702
  --> https://bugs.webkit.org/attachment.cgi?id=345702
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345702&action=review

r=me

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:574
> +		   if (!isFTL(m_graph.m_plan.mode()))

might be nice to have a function like:

bool Plan::isFTL()


More information about the webkit-reviews mailing list