[webkit-reviews] review granted: [Bug 187949] [JSC] Record CoW status in ArrayProfile : [Attachment 345678] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 12:23:58 PDT 2018


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 187949: [JSC] Record CoW status in ArrayProfile
https://bugs.webkit.org/show_bug.cgi?id=187949

Attachment 345678: Patch

https://bugs.webkit.org/attachment.cgi?id=345678&action=review




--- Comment #12 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 345678
  --> https://bugs.webkit.org/attachment.cgi?id=345678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345678&action=review

r=me

> Source/JavaScriptCore/bytecode/ArrayProfile.h:274
> +    ArrayModes m_observedArrayModes { 0 };
> +    unsigned m_observedIndexingModes { 0 };

I think this class would be smaller if you moved these two fields to behind
StructureID


More information about the webkit-reviews mailing list