[webkit-reviews] review granted: [Bug 187936] [Cocoa] Stop crashing in lastResortFallbackFont() : [Attachment 345633] Patch

[bugzilla-daemon at webkit.org]

Jon Lee <jonlee at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 187936: [Cocoa] Stop crashing in lastResortFallbackFont()
https://bugs.webkit.org/show_bug.cgi?id=187936

Attachment 345633: Patch

https://bugs.webkit.org/attachment.cgi?id=345633&action=review




--- Comment #5 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 345633
  --> https://bugs.webkit.org/attachment.cgi?id=345633
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345633&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-1491
> -    return *fontForFamily(fontDescription, AtomicString("Lucida Grande",
AtomicString::ConstructFromLiteral), nullptr, nullptr, { }, false);

The comment above seems no longer to be true. Remove or update?