[webkit-reviews] review granted: [Bug 187830] Reduce getters/setters in WebFramePolicyListenerProxy : [Attachment 345404] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 23 16:00:30 PDT 2018


Dean Jackson <dino at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 187830: Reduce getters/setters in WebFramePolicyListenerProxy
https://bugs.webkit.org/show_bug.cgi?id=187830

Attachment 345404: Patch

https://bugs.webkit.org/attachment.cgi?id=345404&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 345404
  --> https://bugs.webkit.org/attachment.cgi?id=345404
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345404&action=review

> Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:54
> +enum class ShouldProcessSwapIfPossible { No, Yes };

Shouldn't this be ShouldProcessSwap { DoNotProcess, ProcessIfPossible } ?


More information about the webkit-reviews mailing list