[webkit-reviews] review granted: [Bug 187922] WebCore::primaryScreenDisplayID() always return 0 : [Attachment 345604] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 187922: WebCore::primaryScreenDisplayID() always return 0
https://bugs.webkit.org/show_bug.cgi?id=187922

Attachment 345604: Patch

https://bugs.webkit.org/attachment.cgi?id=345604&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 345604
  --> https://bugs.webkit.org/attachment.cgi?id=345604
Patch

r=me

You could probably test this in an automated way if you added a function or
property in window.internals to override screenProperties().primaryDisplayID.
That would at least test the fact that primaryScreenDisplayID() no longer
unconditionally returns 0. (You just need the test harness to remember to