[webkit-reviews] review granted: [Bug 187824] AX: Press tab to highlight items on a webpage is not working with voiceover enabled : [Attachment 345583] patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Nan Wang <n_wang at apple.com>'s request for
review:
Bug 187824: AX: Press tab to highlight items on a webpage is not working with
voiceover enabled
https://bugs.webkit.org/show_bug.cgi?id=187824

Attachment 345583: patch

https://bugs.webkit.org/attachment.cgi?id=345583&action=review




--- Comment #10 from zalan <zalan at apple.com> ---
Comment on attachment 345583
  --> https://bugs.webkit.org/attachment.cgi?id=345583
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345583&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:2861
> +    RefPtr<FrameView> frameView = document().view();
> +    RenderView* renderView = document().renderView();
> +    bool needsLayout = frameView && renderView &&
(frameView->layoutContext().isLayoutPending() || renderView->needsLayout());

if (!document().view() || document().view()->needsLayout())
    return;
This should do (when the tree is dirty there must be a pending layout
scheduled).