[webkit-reviews] review granted: [Bug 187886] runJITThreadLimitTests is failing : [Attachment 345596] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 187886: runJITThreadLimitTests is failing
https://bugs.webkit.org/show_bug.cgi?id=187886

Attachment 345596: Patch

https://bugs.webkit.org/attachment.cgi?id=345596&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 345596
  --> https://bugs.webkit.org/attachment.cgi?id=345596
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345596&action=review

> Source/JavaScriptCore/dfg/DFGWorklist.cpp:538
> +    return numberOfDFGCompilerThreads ?:
Options::numberOfDFGCompilerThreads();

style nit: We don't use shorthand ternary operator style wise in WebKit AFAIK.
So:
return numberOfDFGCompilerThreads ? numberOfDFGCompilerThreads :
Options::numberOfDFGCompilerThreads();

> Source/JavaScriptCore/dfg/DFGWorklist.cpp:543
> +    return numberOfFTLCompilerThreads ?:
Options::numberOfFTLCompilerThreads();

ditto