[webkit-reviews] review granted: [Bug 187871] [iOS] Add support for input[type=color] : [Attachment 345585] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 23 11:27:02 PDT 2018
Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 187871: [iOS] Add support for input[type=color]
https://bugs.webkit.org/show_bug.cgi?id=187871
Attachment 345585: Patch
https://bugs.webkit.org/attachment.cgi?id=345585&action=review
--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 345585
--> https://bugs.webkit.org/attachment.cgi?id=345585
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=345585&action=review
> Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm:114
> + _colorButtons = adoptNS([colorButtons copy]);
In retrospect, there's not even a real reason for this copy.
More information about the webkit-reviews
mailing list