[webkit-reviews] review granted: [Bug 185836] [INTL] Language tags are not canonicalized : [Attachment 345573] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Andy VanWagoner
<andy at vanwagoner.family>'s request for review:
Bug 185836: [INTL] Language tags are not canonicalized
https://bugs.webkit.org/show_bug.cgi?id=185836

Attachment 345573: Patch

https://bugs.webkit.org/attachment.cgi?id=345573&action=review




--- Comment #24 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 345573
  --> https://bugs.webkit.org/attachment.cgi?id=345573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345573&action=review

r=me with some comments.

> Source/JavaScriptCore/Scripts/generateIntlCanonicalizeLanguage.py:113
> +	   # file.write("#include <wtf/HashMap.h>\n")
> +	   # file.write("#include <wtf/NeverDestroyed.h>\n")

Please remove.

> Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp:679
> +    ucal_setGregorianChange(cal, -8.64E15, &status);

What's -8.64E15? Maybe it'd be better as a named const variable?

> Source/JavaScriptCore/runtime/IntlObject.cpp:327
> +		   if (!times) {
> +		       if (intlPreferredExtlangTag(extlangLower) == langtag) {

Nit: Can you make this if (!times && intlPreferredExtlangTag(extlangLower) ==
langtag)

> Source/JavaScriptCore/ucd/language-subtag-registry.txt:1
> +File-Date: 2018-04-23

Does this file have a Copyright? Do we need to do anything there.