[webkit-reviews] review granted: [Bug 187581] webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python : [Attachment 345317] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 187581: webkitpy.port.server_process_unittest.TestServerProcess.test_basic
failed on Windows Python
https://bugs.webkit.org/show_bug.cgi?id=187581

Attachment 345317: Patch

https://bugs.webkit.org/attachment.cgi?id=345317&action=review




--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 345317
  --> https://bugs.webkit.org/attachment.cgi?id=345317
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345317&action=review

r=me

> Tools/Scripts/webkitpy/port/server_process_unittest.py:102
> +	   cmd = [sys.executable, '-uc', 'import sys; print "stdout"; print
>>sys.stderr, "stderr"; sys.stdin.readline();']

For your consideration, I suggest adding a comment to explain -u and why we are
using -u.

> Tools/Scripts/webkitpy/port/server_process_unittest.py:149
> +	   cmd = [sys.executable, '-uc', 'import sys; print "stdout 1"; print
"stdout 2"; print "stdout 3"; sys.stdin.readline(); sys.exit(1);']

Ditto.