[webkit-reviews] review granted: [Bug 186462] [DFG] Fold GetByVal if the indexed value is non configurable and non writable : [Attachment 345537] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 186462: [DFG] Fold GetByVal if the indexed value is non configurable and
non writable
https://bugs.webkit.org/show_bug.cgi?id=186462

Attachment 345537: Patch

https://bugs.webkit.org/attachment.cgi?id=345537&action=review




--- Comment #22 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 345537
  --> https://bugs.webkit.org/attachment.cgi?id=345537
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345537&action=review

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1898
> +		   if (node->arrayMode().type() == Array::ArrayStorage ||
node->arrayMode().type() == Array::SlowPutArrayStorage) {

The name of the lambda this code is inside of needs to be changed since this
extends beyond CoW folding

> Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp:190
> +    WTF::loadLoadFence();

This can use Dependency instead of loadLoadFence so it's fast on ARM if we
decide to support ARM in the future. On x86, if you refactor this to us
Dependency you'll just end up with the same code being emitted.