[webkit-reviews] review granted: [Bug 187883] Fix lldb summarizers for HashMaps and HashSets : [Attachment 345527] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 187883: Fix lldb summarizers for HashMaps and HashSets
https://bugs.webkit.org/show_bug.cgi?id=187883

Attachment 345527: Patch

https://bugs.webkit.org/attachment.cgi?id=345527&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 345527
  --> https://bugs.webkit.org/attachment.cgi?id=345527
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345527&action=review

r=me

> Tools/lldb/lldb_webkit_unittest.py:156
> +    def serial_test_WTFHashMap_tablesize_and_size(self):

Would it be meaningful to add tests for the empty hash table and empty hash
set?