[webkit-reviews] review granted: [Bug 187827] DFG AbstractInterpreter: CheckArray filters array modes for DirectArguments only using NonArray : [Attachment 345466] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 187827: DFG AbstractInterpreter: CheckArray filters array modes for
DirectArguments only using NonArray
https://bugs.webkit.org/show_bug.cgi?id=187827

Attachment 345466: Patch

https://bugs.webkit.org/attachment.cgi?id=345466&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 345466
  --> https://bugs.webkit.org/attachment.cgi?id=345466
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345466&action=review

> Source/JavaScriptCore/ChangeLog:9
> +	   When filtering array modes for DirectArguments and ScopedArguments,
we need to allow for the possibility that

not ScopedArguments.

> Source/JavaScriptCore/ChangeLog:10
> +	   they can either be NonArray or NonArrayWithArrayStorage (aka
ArrayStorageShape).

Might be worth a comment why this is. Also might worth noting why
DirectArguments won't end up with Int32/Double/etc shapes.
(I'd put that explanation here or in a comment in the code perhaps, or both)