[webkit-reviews] review granted: [Bug 183705] REGRESSION(PSON?): [ WK2 ] http/tests/workers/service/client-*-page-cache.html LayoutTests are flaky : [Attachment 345463] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183705: REGRESSION(PSON?): [ WK2 ]
http/tests/workers/service/client-*-page-cache.html LayoutTests are flaky
https://bugs.webkit.org/show_bug.cgi?id=183705

Attachment 345463: Patch

https://bugs.webkit.org/attachment.cgi?id=345463&action=review




--- Comment #10 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 345463
  --> https://bugs.webkit.org/attachment.cgi?id=345463
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345463&action=review

>
LayoutTests/http/tests/workers/service/client-added-to-clients-when-restored-fr
om-page-cache.html:17
> +	 worker.postMessage("getClientCount");

Shouldn't we do the usual pattern:
if (++counter < 20) {
  log("FAIL...")
  finishSWTest();
}
await waitFor(50);
worker.postMessage("getClientCount");

>
LayoutTests/http/tests/workers/service/serviceworkerclients-matchAll-worker.js:
26
> +	       result = await matchAllPromise1;

This loop does not seem useful as is.
We might want to change matchAllPromise1 to a function which would return a new
promise every time it is called.
Again a waitFor(50) might help.