[webkit-reviews] review granted: [Bug 187852] [JSC] A bit performance improvement for Object.assign by cleaning up code : [Attachment 345438] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 187852: [JSC] A bit performance improvement for Object.assign by cleaning
up code
https://bugs.webkit.org/show_bug.cgi?id=187852

Attachment 345438: Patch

https://bugs.webkit.org/attachment.cgi?id=345438&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 345438
  --> https://bugs.webkit.org/attachment.cgi?id=345438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345438&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   2. canDoFastPath is not necessary. Restructuring the code to clean
up things.

I agree this is a bit ugly, but the reason I wrote it that way so was we don't
try to use the Structure* after the source could have potentially transitioned.

I would vote for just loading the structure twice instead of keeping a variable
around that points to something that may no longer be source's structure. (LLVM
should CSE the structure load anyways)