[webkit-reviews] review granted: [Bug 187854] FrameView::paintContents should release log when the render tree is dirty. : [Attachment 345451] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 187854: FrameView::paintContents should release log when the render tree is
dirty.
https://bugs.webkit.org/show_bug.cgi?id=187854

Attachment 345451: Patch

https://bugs.webkit.org/attachment.cgi?id=345451&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 345451
  --> https://bugs.webkit.org/attachment.cgi?id=345451
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345451&action=review

> Source/WebCore/page/FrameView.cpp:4146
> +	   RELEASE_LOG_IF_ALLOWED("painting: Render tree needs layout. Can't
paint at this time -is mainframe(%d)", frame().isMainFrame());

Let's put "FrameView::paintContents" in the log message somewhere. Maybe
"FrameView::paintContents() - not painting because render tree needs layout (is
main frame %d)".