[webkit-reviews] review granted: [Bug 187216] DeclarativeAnimation should suspend, resume, & stop m_eventQueue : [Attachment 345412] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 187216: DeclarativeAnimation should suspend, resume, & stop m_eventQueue
https://bugs.webkit.org/show_bug.cgi?id=187216

Attachment 345412: Patch

https://bugs.webkit.org/attachment.cgi?id=345412&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 345412
  --> https://bugs.webkit.org/attachment.cgi?id=345412
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345412&action=review

> Source/WebCore/animation/DeclarativeAnimation.cpp:220
> +    ActiveDOMObject::suspend(reason);

There is no need to call this. It's empty.
But we should call WebAnimation::suspend(reason) to make this code future
proof.

> Source/WebCore/animation/DeclarativeAnimation.cpp:226
> +    ActiveDOMObject::resume();

Ditto.