[webkit-reviews] review denied: [Bug 184991] We should cache the compiled sandbox profile in a data vault : [Attachment 345311] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied  review:
Bug 184991: We should cache the compiled sandbox profile in a data vault
https://bugs.webkit.org/show_bug.cgi?id=184991

Attachment 345311: Patch

https://bugs.webkit.org/attachment.cgi?id=345311&action=review




--- Comment #121 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 345311
  --> https://bugs.webkit.org/attachment.cgi?id=345311
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345311&action=review

Ben and I went over this patch and I noticed some corr corneas issues and other
stylistic issues. I would like to see another iteration.

> Source/WebKit/Shared/mac/ChildProcessMac.mm:265
> +    temp.resize(neededBufferSize);

This will destroy any data already written into the buffer because the size of
the vector is 0.

> Source/WebKit/Shared/mac/ChildProcessMac.mm:267
> +	   RELEASE_ASSERT(temp.size() == confstrWithCheck());

Can this assert be disabled?