[webkit-reviews] review granted: [Bug 187790] FetchResponse should close its stream when loading finishes : [Attachment 345353] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 19 10:04:10 PDT 2018
Chris Dumez <cdumez at apple.com> has granted review:
Bug 187790: FetchResponse should close its stream when loading finishes
https://bugs.webkit.org/show_bug.cgi?id=187790
Attachment 345353: Patch
https://bugs.webkit.org/attachment.cgi?id=345353&action=review
--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 345353
--> https://bugs.webkit.org/attachment.cgi?id=345353
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=345353&action=review
> Source/WebCore/Modules/fetch/FetchResponse.cpp:259
> + m_response.m_readableStreamSource->error(makeString("Loading
failed"_s, error.localizedDescription()));
Don't we need a ": " between "Loading failed" and the description?
More information about the webkit-reviews
mailing list