[webkit-reviews] review denied: [Bug 187790] FetchResponse should close its stream when loading finishes : [Attachment 345299] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 08:50:16 PDT 2018

Chris Dumez <cdumez at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 187790: FetchResponse should close its stream when loading finishes

Attachment 345299: Patch


--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 345299
  --> https://bugs.webkit.org/attachment.cgi?id=345299

View in context: https://bugs.webkit.org/attachment.cgi?id=345299&action=review

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:50
> +    if (m_readableStreamSource)

m_readableStreamSource gets nulled out in several methods in this class, in
which case, the source may be kept alive (due to refcounting) but will still
have a pointer to this owner. I think we want to clear the source's body owner
in all cases where m_readableStreamSource gets cleared, not used in the
BodyOwner destructor.

> Source/WebCore/Modules/fetch/FetchBodySource.cpp:89
> +void FetchBodySource::cleanBodyOwner()

I do not like "clean", I'd prefer "clear" or "detachFrom"

More information about the webkit-reviews mailing list