[webkit-reviews] review granted: [Bug 186414] Add benchmark for WebKit process launch times : [Attachment 345322] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Ben Richards
<benton_richards at apple.com>'s request for review:
Bug 186414: Add benchmark for WebKit process launch times
https://bugs.webkit.org/show_bug.cgi?id=186414

Attachment 345322: Patch

https://bugs.webkit.org/attachment.cgi?id=345322&action=review




--- Comment #37 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 345322
  --> https://bugs.webkit.org/attachment.cgi?id=345322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345322&action=review

> PerformanceTests/LaunchTime/launch_time.py:275
> +			   results_by_iteration_number[i].append(result_in_ms)

We could also do: results_by_iteration_number.setdefault(i, []) here instead.

> PerformanceTests/LaunchTime/new_tab.py:58
> +	   self.argument_parser.add_argument('-w', '--wait-time',
type=self._parse_wait_time,
> +	       help='wait time to use between iterations or range to scan
(format is "N" or "N:M" where N < M, default:
{}:{})'.format(self.wait_time_low, self.wait_time_high))

Don't we want to specify the wait time for startup test as well?