[webkit-reviews] review denied: [Bug 187786] [WinCairo] Add missing piece for inspecting web inspector : [Attachment 345292] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 187786: [WinCairo] Add missing piece for inspecting web inspector
https://bugs.webkit.org/show_bug.cgi?id=187786

Attachment 345292: Patch

https://bugs.webkit.org/attachment.cgi?id=345292&action=review




--- Comment #4 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 345292
  --> https://bugs.webkit.org/attachment.cgi?id=345292
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345292&action=review

> Source/cmake/OptionsWin.cmake:96
> +SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE})

I think you should define it in OptionsWinCairo.cmake to keep AppleWin port
untouched.

> Tools/ChangeLog:3
> +	   [WinCairo] Add missing piece for inspecting web inspector

What is the missing piece? I like more informative summary.

> ChangeLog:8
> +	   * Source/cmake/OptionsWin.cmake:

This change needs a more informative change log entry.