[webkit-reviews] review granted: [Bug 187788] Let clients override _WKThumbnailView's background color : [Attachment 345305] Attempt.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 18 17:07:39 PDT 2018
Tim Horton <thorton at apple.com> has granted Ricky Mondello
<rmondello at apple.com>'s request for review:
Bug 187788: Let clients override _WKThumbnailView's background color
https://bugs.webkit.org/show_bug.cgi?id=187788
Attachment 345305: Attempt.
https://bugs.webkit.org/attachment.cgi?id=345305&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 345305
--> https://bugs.webkit.org/attachment.cgi?id=345305
Attempt.
View in context: https://bugs.webkit.org/attachment.cgi?id=345305&action=review
> Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm:159
> + [self updateLayer];
Don't you usually setNeedsDisplay, not updateLayer directly?
More information about the webkit-reviews
mailing list