[webkit-reviews] review granted: [Bug 187674] [ews-build] Add build step to run layout-test : [Attachment 345006] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 18 11:33:23 PDT 2018


Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 187674: [ews-build] Add build step to run layout-test
https://bugs.webkit.org/show_bug.cgi?id=187674

Attachment 345006: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=345006&action=review




--- Comment #5 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 345006
  --> https://bugs.webkit.org/attachment.cgi?id=345006
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345006&action=review

r=me, after considering typo fix.

> Tools/BuildSlaveSupport/ews-build/steps.py:264
> +    name = 'layout-test'

should this be 'layout-tests' ?


More information about the webkit-reviews mailing list