[webkit-reviews] review granted: [Bug 187772] Web Inspector: REGRESSION(r232591): CodeMirrorEditor should not use a RegExp lineSeparator option : [Attachment 345261] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 187772: Web Inspector: REGRESSION(r232591): CodeMirrorEditor should not use
a RegExp lineSeparator option
https://bugs.webkit.org/show_bug.cgi?id=187772

Attachment 345261: Patch

https://bugs.webkit.org/attachment.cgi?id=345261&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 345261
  --> https://bugs.webkit.org/attachment.cgi?id=345261
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345261&action=review

r=me

> Source/WebInspectorUI/ChangeLog:15
> +	   it detects \n, \r\n, and \r. By specifying a regular expression we
> +	   merely cause problems when CodeMirror uses the supplied
lineSeparator
> +	   when joining its array of lines together.

Well that stinks.