[webkit-reviews] review granted: [Bug 187751] [CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState : [Attachment 345232] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 187751: [CoordGraphics] Start tracking Nicosia layers in
CoordinatedGraphicsState
https://bugs.webkit.org/show_bug.cgi?id=187751

Attachment 345232: Patch

https://bugs.webkit.org/attachment.cgi?id=345232&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 345232
  --> https://bugs.webkit.org/attachment.cgi?id=345232
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345232&action=review

>
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cp
p:1116
> +    return m_nicosia.layer;

Can this RefPtr contain nullptr? If not, we could probably return a const
Nicosia::CompositionLayer& instead.

> Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:435
> +    // TODO: Start using the Nicosia layer state for updates.

Use FIXME instead of TODO