[webkit-reviews] review canceled: [Bug 187739] -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation : [Attachment 345204] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has canceled Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 187739: -_beginAnimatedResizeWithUpdates: can leave view in bad state if
called during an existing animation
https://bugs.webkit.org/show_bug.cgi?id=187739

Attachment 345204: Patch

https://bugs.webkit.org/attachment.cgi?id=345204&action=review




--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 345204
  --> https://bugs.webkit.org/attachment.cgi?id=345204
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345204&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2925
>> +	    [self _cancelAnimatedResize];
> 
> IIIIII don't know about this one. Does your code do anything even remotely
acceptable if _resizeAnimationView is nil?

Hmm, -indexOfObject: will fail, and we may move _scrollView to the end. But
yeah, that should probably be protected by: "if (!_customContentView &&
_resizeAnimationView)".