[webkit-reviews] review denied: [Bug 187739] -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation : [Attachment 345194] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 187739: -_beginAnimatedResizeWithUpdates: can leave view in bad state if
called during an existing animation
https://bugs.webkit.org/show_bug.cgi?id=187739

Attachment 345194: Patch

https://bugs.webkit.org/attachment.cgi?id=345194&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 345194
  --> https://bugs.webkit.org/attachment.cgi?id=345194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345194&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2906
> +    [_resizeAnimationView removeFromSuperview];

resizeAnimationView has the WKContentView as its subview so you just tossed it.

Look at the existing code that does this to see how to clean up correctly