[webkit-reviews] review granted: [Bug 187710] Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction() : [Attachment 345132] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 187710: Add completion handlers to TestRunner functions
setStatisticsLastSeen(), setStatisticsPrevalentResource(),
setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and
setStatisticsHasHadNonRecentUserInteraction()
https://bugs.webkit.org/show_bug.cgi?id=187710

Attachment 345132: Patch

https://bugs.webkit.org/attachment.cgi?id=345132&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 345132
  --> https://bugs.webkit.org/attachment.cgi?id=345132
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345132&action=review

r=me with nits.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:80
> +    store->setLastSeen(WebCore::URL(WebCore::URL(),
WebKit::toImpl(host)->string()), Seconds { seconds }, [context,
completionHandler]() {

()  not needed.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:94
> +	   store->setPrevalentResource(WebCore::URL(WebCore::URL(),
WebKit::toImpl(host)->string()), [context, completionHandler]() {

()  not needed.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:112
> +	   store->setVeryPrevalentResource(WebCore::URL(WebCore::URL(),
WebKit::toImpl(host)->string()), [context, completionHandler]() {

()  not needed.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:116
> +	   store->clearPrevalentResource(WebCore::URL(WebCore::URL(),
WebKit::toImpl(host)->string()), [context, completionHandler]() {

()  not needed.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:182
> +	   store->logUserInteraction(WebCore::URL(WebCore::URL(),
WebKit::toImpl(host)->string()), [context, completionHandler]() {

()  not needed.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:186
> +	   store->clearUserInteraction(WebCore::URL(WebCore::URL(),
WebKit::toImpl(host)->string()), [context, completionHandler]() {

()  not needed.

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:199
> +    store->logNonRecentUserInteraction(WebCore::URL(WebCore::URL(),
WebKit::toImpl(host)->string()), [context, completionHandler]() {

()  not needed.

> Tools/WebKitTestRunner/TestController.cpp:2720
> +    

Bad extra line.