[webkit-reviews] review granted: [Bug 187713] Release assert in ~TimerBase is getting hit in WK1 apps which uses JSC API directly : [Attachment 345128] Fixed non-iOS builds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 16 19:09:02 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 187713: Release assert in ~TimerBase is getting hit in WK1 apps which uses
JSC API directly
https://bugs.webkit.org/show_bug.cgi?id=187713

Attachment 345128: Fixed non-iOS builds

https://bugs.webkit.org/attachment.cgi?id=345128&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 345128
  --> https://bugs.webkit.org/attachment.cgi?id=345128
Fixed non-iOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=345128&action=review

> Source/WebCore/ChangeLog:8
> +	   Turn this into a debug assertion in WebKit1.

This needs more explanation that mentions the JSC lack of WebThreadLock etc,
and reference a radar.


More information about the webkit-reviews mailing list