[webkit-reviews] review granted: [Bug 187673] Correctly adjust scroll offsets when a page is zoomed : [Attachment 345127] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 187673: Correctly adjust scroll offsets when a page is zoomed
https://bugs.webkit.org/show_bug.cgi?id=187673

Attachment 345127: Patch

https://bugs.webkit.org/attachment.cgi?id=345127&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 345127
  --> https://bugs.webkit.org/attachment.cgi?id=345127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345127&action=review

This looks reasonable to me, with a few minor nits.

> Source/WebCore/ChangeLog:11
> +	   Instead of just setting the offset arbitrarily to 100, use the
screen rect

We should update the ChangeLog to reflect the new changes.

> Source/WebCore/page/ios/EventHandlerIOS.mm:593
> +    CGSize edgeDistanceThreshold = CGRect(unobscuredContentRect).size;

Can we just CGSizeMake(EDGE_DISTANCE_THRESHOLD / zoomFactor,
EDGE_DISTANCE_THRESHOLD / zoomFactor)?