[webkit-reviews] review granted: [Bug 186531] [Datalist][macOS] Add suggestions UI for TextFieldInputTypes : [Attachment 345106] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 186531: [Datalist][macOS] Add suggestions UI for TextFieldInputTypes
https://bugs.webkit.org/show_bug.cgi?id=186531

Attachment 345106: Patch

https://bugs.webkit.org/attachment.cgi?id=345106&action=review




--- Comment #28 from Tim Horton <thorton at apple.com> ---
Comment on attachment 345106
  --> https://bugs.webkit.org/attachment.cgi?id=345106
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345106&action=review

> Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.h:53
> +    NSView *m_view;

What's the lifetime of m_view vs. WebDataListSuggestionsDropdownMac? Is it OK
that this is a raw pointer?