[webkit-reviews] review granted: [Bug 187375] [iOS] When bringing MobileSafari to the foreground, images, which are pending decoding, won't be drawn into the immediate-paint transaction : [Attachment 344970] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 187375: [iOS] When bringing MobileSafari to the foreground, images, which
are pending decoding, won't be drawn into the immediate-paint transaction
https://bugs.webkit.org/show_bug.cgi?id=187375

Attachment 344970: Patch

https://bugs.webkit.org/attachment.cgi?id=344970&action=review




--- Comment #20 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 344970
  --> https://bugs.webkit.org/attachment.cgi?id=344970
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344970&action=review

> Source/WebCore/loader/cache/CachedImage.cpp:143
> +bool CachedImage::isPendingImageDrawingClient(CachedImageClient& client)
const

This function name is hard to parse. Does it mean "Is client of pending image
drawing" or "has image drawing client which is pending (something)"?

> Source/WebCore/loader/cache/CachedImage.cpp:167
> +void CachedImage::clearPendingImageDrawingClient()

Also hard to parse.

> Source/WebCore/platform/graphics/GraphicsContext.h:262
> +    enum class PaintInvalidationReasons {

: unint8_t