[webkit-reviews] review denied: [Bug 187682] Add an SPI hook to allow clients to yield document parsing and script execution : [Attachment 345048] First pass

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 187682: Add an SPI hook to allow clients to yield document parsing and
script execution
https://bugs.webkit.org/show_bug.cgi?id=187682

Attachment 345048: First pass

https://bugs.webkit.org/attachment.cgi?id=345048&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 345048
  --> https://bugs.webkit.org/attachment.cgi?id=345048
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=345048&action=review

r- due to perf concerns.

> Source/WebCore/html/parser/HTMLParserScheduler.cpp:118
> +    if (UNLIKELY(m_parser.document()->hasActiveParserYieldToken()))

We can't load parser & document like this. This will regress perf.
Add a flag on the HTMLParserScheduler itself and have Document's method update
that instead.

> Source/WebCore/html/parser/HTMLParserScheduler.h:-66
> -    bool shouldYieldBeforeToken(PumpSession& session)

We can't move this out of the header. It's very important that this function is
inlined.
Otherwise, we'd regress the perf.