[webkit-reviews] review denied: [Bug 187694] [GLIB] Add jsc_context_check_syntax() to GLib API : [Attachment 345090] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 187694: [GLIB] Add jsc_context_check_syntax() to GLib API
https://bugs.webkit.org/show_bug.cgi?id=187694

Attachment 345090: Patch

https://bugs.webkit.org/attachment.cgi?id=345090&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 345090
  --> https://bugs.webkit.org/attachment.cgi?id=345090
Patch

Looks good. But, I think this API does not consider about ES6 modules.
Module and Script have different syntax elements. For example, `import`
declaration is not allowed under Script mode.
We should take an argument indicating the mode.