[webkit-reviews] review granted: [Bug 187343] [WebVR] Add support for connect/disconnect and mount/unmount device events : [Attachment 345087] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 187343: [WebVR] Add support for connect/disconnect and mount/unmount device
events
https://bugs.webkit.org/show_bug.cgi?id=187343

Attachment 345087: Patch

https://bugs.webkit.org/attachment.cgi?id=345087&action=review




--- Comment #6 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 345087
  --> https://bugs.webkit.org/attachment.cgi?id=345087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345087&action=review

> Source/WebCore/Modules/webvr/VRDisplay.h:92
> +    // VRPlatformDisplayClient implementation.
> +    void platformDisplayConnected() override;
> +    void platformDisplayDisconnected() override;
> +    void platformDisplayMounted() override;
> +    void platformDisplayUnmounted() override;

These should be private, if possible.

> Source/WebCore/platform/vr/VRManager.cpp:56
> +    auto displays = m_platformManager->getVRDisplays();

You can inline this into the range-based for-loop:

    for (auto& display : m_platformManager->getVRDisplays())

> Source/WebCore/platform/vr/VRPlatformDisplayClient.h:32
> +    virtual ~VRPlatformDisplayClient() { }

Nit: this virtual dtor should be above the methods.