[webkit-reviews] review granted: [Bug 187686] Shrink some font-related classes and enums : [Attachment 345060] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted  review:
Bug 187686: Shrink some font-related classes and enums
https://bugs.webkit.org/show_bug.cgi?id=187686

Attachment 345060: Patch

https://bugs.webkit.org/attachment.cgi?id=345060&action=review




--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 345060
  --> https://bugs.webkit.org/attachment.cgi?id=345060
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345060&action=review

r=me assuming you fix Windows

> Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm:58
> +    uintptr_t flags =
static_cast<uintptr_t>(static_cast<unsigned>(m_widthVariant) << 6 |
m_isHashTableDeletedValue << 5 | static_cast<unsigned>(m_textRenderingMode) <<
3 | static_cast<unsigned>(m_orientation) << 2 | m_syntheticBold << 1 |
m_syntheticOblique);

Nit: this is now long enough to break up into separate lines.

> Source/WebCore/platform/text/TextFlags.h:363
> +enum class FontSmallCaps : uint8_t {

Are enum classes required for the : uint8_t?