[webkit-reviews] review granted: [Bug 187680] Shrink some style-related classes and enums : [Attachment 345040] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 14 16:31:22 PDT 2018


Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 187680: Shrink some style-related classes and enums
https://bugs.webkit.org/show_bug.cgi?id=187680

Attachment 345040: Patch

https://bugs.webkit.org/attachment.cgi?id=345040&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 345040
  --> https://bugs.webkit.org/attachment.cgi?id=345040
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345040&action=review

> Source/WebCore/ChangeLog:12
> +	   Shrink DocumentRuleSet from 384 to 368 bytes by re-ordering, which
also helps shrink
> +	   StyleResolver from 1024 to 952 bytes.

Micro-optimizing low volume objects like DocumentRuleSet does not produce
meaningful gain. Still, cleanups are nice.


More information about the webkit-reviews mailing list