[webkit-reviews] review granted: [Bug 187546] Shrink CachedResource and subclasses : [Attachment 344749] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 187546: Shrink CachedResource and subclasses
https://bugs.webkit.org/show_bug.cgi?id=187546

Attachment 344749: Patch

https://bugs.webkit.org/attachment.cgi?id=344749&action=review




--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 344749
  --> https://bugs.webkit.org/attachment.cgi?id=344749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344749&action=review

> Source/WebCore/loader/cache/CachedResource.h:335
> +    CachedResourceLoader* m_owningCachedResourceLoader { nullptr }; // only
non-null for resources that are not in the cache

Please make the comment a proper sentence.

> Source/WebCore/platform/network/NetworkLoadMetrics.h:42
> +enum class NetworkLoadPriority : uint8_t {

I take it the compiler is not smart enough to store these in a uint8_t without
the annotation. Is this a bug in clang?

> Source/WebCore/platform/network/ResourceRequestBase.h:86
> +    enum class SameSiteDisposition : uint8_t { Unspecified, SameSite,
CrossSite };

Ditto.

> Source/WebCore/platform/network/ResourceRequestBase.h:167
> +    enum class Requester : uint8_t { Unspecified, Main, XHR, Fetch, Media,
ImportScripts };

Ditto.