[webkit-reviews] review requested: [Bug 187639] [GLIB] Add API to evaluate code using a given object to store global symbols : [Attachment 345034] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 14 04:41:53 PDT 2018
Carlos Garcia Campos <cgarcia at igalia.com> has asked for review:
Bug 187639: [GLIB] Add API to evaluate code using a given object to store
global symbols
https://bugs.webkit.org/show_bug.cgi?id=187639
Attachment 345034: Patch
https://bugs.webkit.org/attachment.cgi?id=345034&action=review
--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 345034
--> https://bugs.webkit.org/attachment.cgi?id=345034&action=review
Patch
Updated the API again. I've realized that it doesn't make sense to limit the
new object as property of the context global object, you might want to add the
object to a namespace object, for example. Now that API returns the object as
an out parameter so that you can add it to any other object.
More information about the webkit-reviews
mailing list