[webkit-reviews] review granted: [Bug 187667] Ensure WebKit stack is ad-hoc signed : [Attachment 344999] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Kocsen Chung
<kocsen_chung at apple.com>'s request for review:
Bug 187667: Ensure WebKit stack is ad-hoc signed
https://bugs.webkit.org/show_bug.cgi?id=187667

Attachment 344999: Patch

https://bugs.webkit.org/attachment.cgi?id=344999&action=review




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 344999
  --> https://bugs.webkit.org/attachment.cgi?id=344999
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344999&action=review

Looks reasonable to me. I'm not sure what's up with mac-wk2 EWS. Probably the
machine is in a bad state, but who knows what repercussions this patch has.

> Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:3
> +CODE_SIGN_IDENTITY = - ;

I wouldn't be adding spaces before the semicolon.