[webkit-reviews] review granted: [Bug 187427] [Curl] Move HTTP Setup logic from CurlRequest to CurlHandle for reuse. : [Attachment 344860] FIX

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 187427: [Curl] Move HTTP Setup logic from CurlRequest to CurlHandle for
reuse.
https://bugs.webkit.org/show_bug.cgi?id=187427

Attachment 344860: FIX

https://bugs.webkit.org/attachment.cgi?id=344860&action=review




--- Comment #12 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 344860
  --> https://bugs.webkit.org/attachment.cgi?id=344860
FIX

View in context: https://bugs.webkit.org/attachment.cgi?id=344860&action=review

> Source/WebCore/platform/network/curl/CurlContext.cpp:360
> +    m_url = url.isolatedCopy();

IIUC, This isolatedCopy is not needed because CurlRequest::m_request is an
isolated copy.

> Source/WebCore/platform/network/curl/CurlSSLVerifier.cpp:85
> +	   m_curlHandle.setSslVerifyPeer(CurlHandle::VerifyPeer::Disable);

Just out of curiosity, Why is this code needed?