[webkit-reviews] review granted: [Bug 187600] [GStreamer] Add GstBufferMapped abstraction : [Attachment 344842] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 187600: [GStreamer] Add GstBufferMapped abstraction
https://bugs.webkit.org/show_bug.cgi?id=187600

Attachment 344842: Patch

https://bugs.webkit.org/attachment.cgi?id=344842&action=review




--- Comment #4 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 344842
  --> https://bugs.webkit.org/attachment.cgi?id=344842
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344842&action=review

>
Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer
.cpp:303
> +		   gst_byte_reader_free(reader);

Interesting catch! We should do this (not necessarily now) a GUniquePtr.