[webkit-reviews] review granted: [Bug 187624] PingLoad does not need to ref the NetworkConnectionToWebProcess : [Attachment 344893] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 12 15:59:20 PDT 2018


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 187624: PingLoad does not need to ref the NetworkConnectionToWebProcess
https://bugs.webkit.org/show_bug.cgi?id=187624

Attachment 344893: Patch

https://bugs.webkit.org/attachment.cgi?id=344893&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 344893
  --> https://bugs.webkit.org/attachment.cgi?id=344893
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344893&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:270
> +    auto completionHandler = [connection = m_connection.copyRef(),
identifier = loadParameters.identifier] (const ResourceError& error, const
ResourceResponse& response) {

Is it really safe?
LOL ;)


More information about the webkit-reviews mailing list