[webkit-reviews] review granted: [Bug 187374] [iOS] When asking for FlushImmediately, the UIProcess should ignore all the layer tree transactions which are sent before this request is received by the WebProcess : [Attachment 344854] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 187374: [iOS] When asking for FlushImmediately, the UIProcess should ignore
all the layer tree transactions which are sent before this request is received
by the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=187374

Attachment 344854: Patch

https://bugs.webkit.org/attachment.cgi?id=344854&action=review




--- Comment #14 from Tim Horton <thorton at apple.com> ---
Comment on attachment 344854
  --> https://bugs.webkit.org/attachment.cgi?id=344854
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344854&action=review

> Source/WebKit/ChangeLog:3
> +	   [iOS] When asking for FlushImmediately, the UIProcess should ignore
all the layer tree transactions which are sent before this request is received
by the WebProcess

The title could use some love. “When asking for FlushImmediately” means nothing
to me unless I already have context.

Also, we’re not /ignoring/ them (that would be disastrous), we’re just
synchronously applying a bunch in a row.

> Source/WebKit/Shared/DrawingAreaInfo.h:42
> +    ActivityStateChangeIDNil = 0

Not really better. Go with the previous one.