[webkit-reviews] review granted: [Bug 187553] REGRESSION (r232356): After zooming a page in and out, it's possible to temporarily have missing tiles (google.com, apple.com) : [Attachment 344839] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 187553: REGRESSION (r232356): After zooming a page in and out, it's
possible to temporarily have missing tiles (google.com, apple.com)
https://bugs.webkit.org/show_bug.cgi?id=187553

Attachment 344839: patch

https://bugs.webkit.org/attachment.cgi?id=344839&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 344839
  --> https://bugs.webkit.org/attachment.cgi?id=344839
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344839&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.h:1669
> +    float m_lastTransactionPageScaleFactor { 0 };

We store page scale as a double in RemoteLayerTreeTransaction and we've
certainly had bugs with float/double precision mismatch before, so should this
be a double, and/or do matching with epsilon?

> Source/WebKit/WebProcess/WebPage/WebPage.h:1670
> +    uint64_t m_lastTransactionIDWithScaleChange { 0 };

I wish we had a typedef for transactionIDs :(