[webkit-reviews] review granted: [Bug 187564] IndexedDB: database file of subframe cannot be removed : [Attachment 344819] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 187564: IndexedDB: database file of subframe cannot be removed
https://bugs.webkit.org/show_bug.cgi?id=187564

Attachment 344819: Patch

https://bugs.webkit.org/attachment.cgi?id=344819&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 344819
  --> https://bugs.webkit.org/attachment.cgi?id=344819
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344819&action=review

> Source/WebCore/ChangeLog:10
> +	   IDBServer should delete database files recursively to make sure all
files are removed.

LGTM.

Let's say that we have the following IDB databases:
IDB1: top level frame origin A with subframe origin A
IDB2: top level frame origin A with subframe origin B
IDB3: top level frame origin B with subframe origin A.
IDB4: top level frame origin B with subframe origin C.

When user asks to delete all databases from origin A, we should probably delete
IDB1, IDB2 and IDB3.

Before the patch, it seems we were deleting IDB1.
After the patch, we are also deleting IDB2.
Is that right? What about IDB3?