[webkit-reviews] review granted: [Bug 187353] [webkitpy] run-web-platform-tests should allow specifying custom WPT metadata directories : [Attachment 344351] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 187353: [webkitpy] run-web-platform-tests should allow specifying custom
WPT metadata directories
https://bugs.webkit.org/show_bug.cgi?id=187353

Attachment 344351: Patch

https://bugs.webkit.org/attachment.cgi?id=344351&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 344351
  --> https://bugs.webkit.org/attachment.cgi?id=344351
Patch

LGTM.
Generating this manifest.json takes time IIRC so we might think of the best way
to cache/checkin/update this file.

View in context: https://bugs.webkit.org/attachment.cgi?id=344351&action=review

> Tools/Scripts/webkitpy/w3c/wpt_runner.py:200
> +		   _log.error("Existent wpt metadata directory has to be
specified")

s/Existent/Existing/
This test could probably be done in WPTRunner __init__

> Tools/Scripts/webkitpy/w3c/wpt_runner.py:203
> +	       include_manifest_path =
self._host.filesystem.join(metadata_path, self._port.name(),
"TestManifest.ini")

Maybe add a helper routine to create the manifest path from a root metatada
path?